Posts: 425
Threads: 424
Joined: Aug 2020
05-03-2021, 04:15 PM
(This post was last modified: 05-24-2021, 07:14 PM by github_bot. Edited 2 times in total.)
PULL REQUEST DETAILS
[BALANCE] [INPUT WANTED] [WIKI]
About the PR
Makes the HoS able to unauth the armory, it has a cooldown to prevent spamming auth messages, 5 minutes, might be too much, unsure, one thing I wish I had done but I couldn't wrap my head around it was making unauthing it send a pda message to the sec mail group, I am also unsure if the sounds I used are good, they were the best things I could think of, I am taking suggestions.
Why's this needed?
It is a pretty common request from HoS players as there is currently no way of closing the armory after it has been authorized.
Changelog
Code:
changelog
(u)Arthur Holiday
(*)The HoS can now unauthorize the armory.
Posts: 215
Threads: 23
Joined: Jul 2020
BYOND Username: Drewmajor11
Character Name: Echo Five
Please. I've seen sec officers auth and break into armory for pod phasers multiple times or just because "I want gun"
Posts: 430
Threads: 16
Joined: Oct 2020
BYOND Username: Froggit_Dogget
Character Name: Investigangster Klutz / Sergeant Killbees / Mr. Stinkfart
Posts: 466
Threads: 16
Joined: Aug 2020
BYOND Username: Nefarious6th
Posts: 2,656
Threads: 33
Joined: Nov 2013
BYOND Username: KikiMofo
Yeah probably a pretty good idea.
Posts: 630
Threads: 33
Joined: Sep 2017
BYOND Username: Drago156
Character Name: Drago Kitterson, Frex Lutlie
I might not play any more, but this is a long needed PR. Too many cases of Armory getting authed 5-10 minutes in or some shit HoP/Captain convincing two other seccies to auth and annoying the hell out of the HoS and rest of security.
Posts: 69
Threads: 1
Joined: May 2019
BYOND Username: Getbrecked
Character Name: Armin Hummer
Good PR. Excellent PR. AMAZING PR.
Posts: 246
Threads: 20
Joined: Sep 2020
BYOND Username: PinkPuffball81
Character Name: Franziska Jackson, T.S.U.N, Bonk Honkem, Jim Reaper
(05-03-2021, 04:31 PM)Drewmajor11 Wrote: Please. I've seen sec officers auth and break into armory for pod phasers multiple times or just because "I want gun"
hos gib me shotgun
Posts: 43
Threads: 2
Joined: Nov 2020
BYOND Username: Annoyed Egg
Character Name: Rube Quirin
Yes. The amount of times I've seen it authed w/o reason is silly and this should hopefully help.
Posts: 1,595
Threads: 203
Joined: Aug 2019
BYOND Username: Cthucky
Maybe add a way for the HoS to see what assholes authorized it so they know who to yell at.
Posts: 2,456
Threads: 113
Joined: Feb 2017
BYOND Username: Technature
(05-04-2021, 03:13 PM)Mouse Wrote: Maybe add a way for the HoS to see what assholes authorized it so they know who to yell at.
Even though it doesn't happen on RP, I can already tell this PR is badly needed.
Posts: 116
Threads: 8
Joined: Mar 2021
BYOND Username: coolvape
(05-04-2021, 03:13 PM)Mouse Wrote: Maybe add a way for the HoS to see what assholes authorized it so they know who to yell at.
that would be really nice, maybe with an additional notification over the security pda channel each time an authorization is added or revoked?
Posts: 2,656
Threads: 33
Joined: Nov 2013
BYOND Username: KikiMofo
I mean you could also just use a finger print scanner to tell who touched the button
Posts: 229
Threads: 5
Joined: Oct 2020
BYOND Username: THISISANICEGAME
Character Name: Arthur Holiday
Using the armory computer doesn't add your fingerprints to it wich is silly, I have pushed a commit to my PR making it so it does add them hopefuly that is enough to identify the sec officers. thanks for reminding me
Posts: 2,656
Threads: 33
Joined: Nov 2013
BYOND Username: KikiMofo
Ah really? Yeah that's also a good idea.
Goonhub
