Goonstation Forums
[MERGED PR] Makes the armory auth cancelable by the HoS - Printable Version

+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Ideas & Suggestions (https://forum.ss13.co/forumdisplay.php?fid=8)
+---- Forum: Good ideas! (https://forum.ss13.co/forumdisplay.php?fid=19)
+---- Thread: [MERGED PR] Makes the armory auth cancelable by the HoS (/showthread.php?tid=16330)



[MERGED PR] Makes the armory auth cancelable by the HoS - github_bot - 05-03-2021

PULL REQUEST DETAILS

[BALANCE] [INPUT WANTED] [WIKI]


About the PR
Makes the HoS able to unauth the armory, it has a cooldown to prevent spamming auth messages, 5 minutes, might be too much, unsure, one thing I wish I had done but I couldn't wrap my head around it was making unauthing it send a pda message to the sec mail group, I am also unsure if the sounds I used are good, they were the best things I could think of, I am taking suggestions.

Why's this needed?
It is a pretty common request from HoS players as there is currently no way of closing the armory after it has been authorized.
Changelog


Code:
changelog
(u)Arthur Holiday
(*)The HoS can now unauthorize the armory.


PULL REQUEST DETAILS


RE: [PR] Makes the armory auth cancelable by the HoS - Drewmajor11 - 05-03-2021

Please. I've seen sec officers auth and break into armory for pod phasers multiple times or just because "I want gun"


RE: [PR] Makes the armory auth cancelable by the HoS - Froggit_Dogget - 05-03-2021

yes please


RE: [PR] Makes the armory auth cancelable by the HoS - nefarious6th - 05-03-2021

finally


RE: [PR] Makes the armory auth cancelable by the HoS - KikiMofo - 05-03-2021

Yeah probably a pretty good idea.


RE: [PR] Makes the armory auth cancelable by the HoS - Drago156 - 05-03-2021

I might not play any more, but this is a long needed PR. Too many cases of Armory getting authed 5-10 minutes in or some shit HoP/Captain convincing two other seccies to auth and annoying the hell out of the HoS and rest of security.


RE: [PR] Makes the armory auth cancelable by the HoS - getbrecked - 05-04-2021

Good PR. Excellent PR. AMAZING PR.


RE: [PR] Makes the armory auth cancelable by the HoS - TheRealFlapJackson - 05-04-2021

(05-03-2021, 04:31 PM)Drewmajor11 Wrote: Please. I've seen sec officers auth and break into armory for pod phasers multiple times or just because "I want gun"

hos gib me shotgun  sad greater domestic space-bee


RE: [PR] Makes the armory auth cancelable by the HoS - Annoyed Egg - 05-04-2021

Yes. The amount of times I've seen it authed w/o reason is silly and this should hopefully help.


RE: [PR] Makes the armory auth cancelable by the HoS - Mouse - 05-04-2021

Maybe add a way for the HoS to see what assholes authorized it so they know who to yell at.


RE: [PR] Makes the armory auth cancelable by the HoS - Technature - 05-04-2021

(05-04-2021, 03:13 PM)Mouse Wrote: Maybe add a way for the HoS to see what assholes authorized it so they know who to yell at.

Even though it doesn't happen on RP, I can already tell this PR is badly needed.


RE: [PR] Makes the armory auth cancelable by the HoS - coolvape - 05-04-2021

(05-04-2021, 03:13 PM)Mouse Wrote: Maybe add a way for the HoS to see what assholes authorized it so they know who to yell at.

that would be really nice, maybe with an additional notification over the security pda channel each time an authorization is added or revoked?


RE: [PR] Makes the armory auth cancelable by the HoS - KikiMofo - 05-05-2021

I mean you could also just use a finger print scanner to tell who touched the button


RE: [PR] Makes the armory auth cancelable by the HoS - THISISANICEGAME - 05-05-2021

Using the armory computer doesn't add your fingerprints to it wich is silly, I have pushed a commit to my PR making it so it does add them hopefuly that is enough to identify the sec officers. thanks for reminding me smile


RE: [PR] Makes the armory auth cancelable by the HoS - KikiMofo - 05-05-2021

Ah really? Yeah that's also a good idea.