Goonhub
12-07-2024, 02:56 AM
(This post was last modified: 12-07-2024, 05:18 AM by github_bot. Edited 5 times in total.)
PULL REQUEST DETAILS
[INPUT WANTED] [CONTROVERSIAL] [FEATURE]
About the PR
Renames all bibles to the holy texts. Moves bible to be a scripture. Adds scriptures for all irl religions with outfits in the chaplain vendor. Changes atheist trait icon and faith to match.
![[Image: 0552f074-6b74-4ec7-bd82-a8c182b60203]](https://github.com/user-attachments/assets/0552f074-6b74-4ec7-bd82-a8c182b60203)
![[Image: 4c3d2b53-8c4b-4a2e-9891-40933f846bc7]](https://github.com/user-attachments/assets/4c3d2b53-8c4b-4a2e-9891-40933f846bc7)
Why's this needed?
Some context and history on bible changes. Please look through so you don't suggest something that's already been tried and denied.
#15132 was the first iteration of this for the Chaplain Additions project, it also had all of what are scriptures today as bible variants. It was closed due to this reasoning by devs namely @Flaborized (comment says individual opinion but it was acted upon and the final note for closing the PR.)
"I think I said this in the Discord already but I'll say again here: I don't personally (this is my opinion and not an Official Dev View) like the idea of adding lots of reskins to Bibles, since Bibles have tons and tons of unique mechanics tied to them. They kill you instantly if you fart on them, have shared storage, can contain the chaplain's gun, "heal" people, and can damage two specific antags (one of which can't even hold the thing without giving themselves away and taking damage). I think an item with this many important features tied to it should have very consistent visuals, and I don't think making it less clear which item is/isn't a holy book that does all these things is worth the RP potential, especially when you can already make custom books."
#17965 was merged with scripture books and some cool outfits based on these changes, but not the bible redo, although the insignia for the bible change was merged on the vendor.
#21564 was done very recently, it was not rejected but closed by me to make this proposal fresh + I somehow had a merge conflict with secret. The forum responses while mainly were supportive still wanted the bible in some form for RP reasons.
I made this PR because Chaplain represents more then Catholicism here and having some of your equipment have those traits regardless of your religion your actually playing and practising can be a bit jarring. As established only 1 book should have the powerful and potentially round-ending effects of the bible. This makes "The Gameplay Book" neutral in regards to religions just being divine in nature to make sense for any chaplain. The RP alternatives are in the vendor now to appease people effected by that, along with new ones to represent the other religions with existing presence in the game.
Changelog
PULL REQUEST DETAILS
[INPUT WANTED] [CONTROVERSIAL] [FEATURE]
About the PR
Renames all bibles to the holy texts. Moves bible to be a scripture. Adds scriptures for all irl religions with outfits in the chaplain vendor. Changes atheist trait icon and faith to match.
Why's this needed?
Some context and history on bible changes. Please look through so you don't suggest something that's already been tried and denied.
#15132 was the first iteration of this for the Chaplain Additions project, it also had all of what are scriptures today as bible variants. It was closed due to this reasoning by devs namely @Flaborized (comment says individual opinion but it was acted upon and the final note for closing the PR.)
"I think I said this in the Discord already but I'll say again here: I don't personally (this is my opinion and not an Official Dev View) like the idea of adding lots of reskins to Bibles, since Bibles have tons and tons of unique mechanics tied to them. They kill you instantly if you fart on them, have shared storage, can contain the chaplain's gun, "heal" people, and can damage two specific antags (one of which can't even hold the thing without giving themselves away and taking damage). I think an item with this many important features tied to it should have very consistent visuals, and I don't think making it less clear which item is/isn't a holy book that does all these things is worth the RP potential, especially when you can already make custom books."
#17965 was merged with scripture books and some cool outfits based on these changes, but not the bible redo, although the insignia for the bible change was merged on the vendor.
#21564 was done very recently, it was not rejected but closed by me to make this proposal fresh + I somehow had a merge conflict with secret. The forum responses while mainly were supportive still wanted the bible in some form for RP reasons.
I made this PR because Chaplain represents more then Catholicism here and having some of your equipment have those traits regardless of your religion your actually playing and practising can be a bit jarring. As established only 1 book should have the powerful and potentially round-ending effects of the bible. This makes "The Gameplay Book" neutral in regards to religions just being divine in nature to make sense for any chaplain. The RP alternatives are in the vendor now to appease people effected by that, along with new ones to represent the other religions with existing presence in the game.
Changelog
Code:
changelog
(u)Cheekybrdy
(*)Replaced bible with the holy texts. Bibles are still avaliable but as scriptures in the chaplain vendor. The Quran, Tripitaka, The theory of evolution, Torah and the Guru Granth Sahibih are also now avaliable in the chaplain vendor as scriptures.PULL REQUEST DETAILS