Goonhub
03-09-2020, 09:34 PM
(This post was last modified: 03-09-2020, 09:36 PM by mbc. Edited 1 time in total.)
patch looks good, some notes :
- I don't think we should do `istype() human` checks in input.dm, seems slow and you could just check dir_locked alone i think
- This should probably freeze movement in the same way stuns/buckles do. instead of checking the 'dabbing' flag on /living/Move() and human/restrained(), add some sort of 'emote lock' flag to mobs and check for it in the update_canmove() proc in Life.dm
then you can do this, when you want to freeze/unfreeze movement:
- I don't think we should do `istype() human` checks in input.dm, seems slow and you could just check dir_locked alone i think
- This should probably freeze movement in the same way stuns/buckles do. instead of checking the 'dabbing' flag on /living/Move() and human/restrained(), add some sort of 'emote lock' flag to mobs and check for it in the update_canmove() proc in Life.dm
then you can do this, when you want to freeze/unfreeze movement:
Code:
mob.emote_lock = 1
mob.update_canmove()
[..]
mob.emote_lock = 0
mob.update_canmove()