+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Patches (https://forum.ss13.co/forumdisplay.php?fid=30)
+---- Forum: Implemented (https://forum.ss13.co/forumdisplay.php?fid=31)
+---- Thread: [Feature] Dab animations (/showthread.php?tid=14050)
[Feature] Dab animations - moonlol - 03-07-2020
At long last the fabled patch is complete.
its seamless. and has depth shadowing
it is the perfect patch.
GAZE UPON IT:
https://gyazo.com/598d069f9cde74ad7be51fc2166b5d25
(it auto locks your movement and dir changing in order to not break the animation)
(this could be used for other things probably)
github compare:
https://github.com/goonstation/goonstation-2020/compare/master...moonlol:dabanimation
RE: [Feature] Dab animations - Kak0phony - 03-07-2020
My god... It's beautiful.....
RE: [Feature] Dab animations - Avatharian - 03-07-2020
I have gazed upon the face of God
and They have found us wanting.
RE: [Feature] Dab animations - Triacontakai - 03-07-2020
this is perfect
RE: [Feature] Dab animations - Ines - 03-07-2020
Perish (love it)
RE: [Feature] Dab animations - Lady Birb - 03-07-2020
merge merge merge
RE: [Feature] Dab animations - aft2001 - 03-08-2020
YES
OH MY GOD YES
MERGE IT
RE: [Feature] Dab animations - phyvo - 03-08-2020
Does it work with mutants? I imagine it could look very bad on lizards/roaches/squidpeople. Otherwise it's great.
RE: [Feature] Dab animations - moonlol - 03-08-2020
it uses alpha masks so it will work on all mutant races or should (apart from like martian and monkey probs)
RE: [Feature] Dab animations - phyvo - 03-09-2020
Awesome!
RE: [Feature] Dab animations - mbc - 03-09-2020
patch looks good, some notes :
- I don't think we should do `istype() human` checks in input.dm, seems slow and you could just check dir_locked alone i think
- This should probably freeze movement in the same way stuns/buckles do. instead of checking the 'dabbing' flag on /living/Move() and human/restrained(), add some sort of 'emote lock' flag to mobs and check for it in the update_canmove() proc in Life.dm
then you can do this, when you want to freeze/unfreeze movement:
Code:
mob.emote_lock = 1
mob.update_canmove()
[..]
mob.emote_lock = 0
mob.update_canmove()RE: [Feature] Dab animations - Kovirii - 03-10-2020
This is the single most amazing thing I have ever laid eyes upon.
RE: [Feature] Dab animations - mbc - 03-10-2020
merged w/ suggested fixes