Reworking Motives (I’ve got the Joy edition)

[ZeWaka]

I really like this! Motives haven't been in the best spot for a while now, and this seems like a good compromise.

also big note: we(kyle)'re in the process of merging the organ patch, which would make things like stomach organs actually things!

Re: actual implementation, I'm going to go over some stuff that would be prohibitive in actually bringing this to SS13. I really like everything else, but I'm just going to go over the potential problems I see. Not trying to shit on everything, but I just want to bring up problems from a coding standpoint.

Spoiler!

3. Players eating in your presence locks your movement, causing you to stare ravenously.

Potentially expensive. Eating is not really built for this, on a completed Eat the function would need to loop through mobs in viewers and then check their hunger status and then apply a stun effect, which could get expensive fast, especially if you eat 100 things in 5 seconds.

[/b]Nutrients is a chemical pill which is available in medical/medical vending machines. When ingested it will heal the player over time to 30 hunger points. If player is above 30 hunger points, it has no effect. 

I think it would be better if this was replaced with an existing chemical?

1. By being an Ailment, this means it shows up on a health scanner (like shock, cardiac arrest, etc). For the purposes of coding, hunger and extreme hunger should be kept as separate ailments, same for thirst. 

imp. note: child

2. This adds an food overlay to the player, so Terrance Philip looks like a big pizza waltzing around.

unclear. would you still be able to interact with said player? overlay would just be visible to you, i presume... would require some weird stuff, akin to hallucinations but not separate objs

+2 an item of clothing gets a a dirty prefix*

imp. note: would need onDirty event calling to holder mob

+2 witnessing a corpse
+5 in the presence of a corpse*
+10 witnessing a cluwne
+100 witnessing a Floor cluwne
-5 witnessing a clown
-20 witnessing Santa

all have potential for badcode/extreme lag. what defines 'witnessing'/'in presence'? is it every single tick you get +2? once per minute?
for minute thing, would need entire loop thread dedicated to processing that stuff, and would be extremely expensive imo having to loop through view of all mobs to find thing via already expensive istype

+10 if brought into critical health
+10 if starving or dehydrated
-10 Eating a painkiller if in red health/critical or is effected by pain
-10 Curing dehydration or starvation

potential for badcode/extreme lag. take the case of a player faced with incompent doctor. doctor heals them to above crit, then they fall back, repeat over and over. this would be +500 stress. unless you have a timer saying it only happens every minute (adds expensive load) this can easily fall apart.

+10 a player dying in your presence.*
+10 witnessing a wizard/vampire/wraith/changeling cast an ability for the first time.
+15 witnessing a changeling eat a person.
+15 witnessing a werewolf for the first time.
+15 witnessing a wraith take form
+30 witnessing a changeling go abomination
+30 witnessing a revenant rise from the grave
-5 Initial sip of tea or coffee.
-5 seeing the clown make a mistake
-100 witnessing the clown die.

would all need event handlers attached to the relevant proc to search through viewers and increment. first time ones would be extra expensive, require var/bitfield flag on /mob

-10 entering the escape shuttle
-20 Having over 5000 credits on your person

similar problem to medical shit above. what stops me from entering and exiting over and over, or going through cash stuff

-10 Ingesting Fluoxetine. Addictive.*
-25 Ingesting Joy pill.*

similar to above, what stops me from making .001u CHEM pills, would require a multiplicative capped

-5 eating a meal cooked by the chef or a drink made by a barman

imp. note: .creator var, maybe already via admin fingerprinting