Posts: 72
Threads: 15
Joined: Jan 2018
BYOND Username: Moonlol
At long last the fabled patch is complete.
its seamless. and has depth shadowing
it is the perfect patch.
GAZE UPON IT:
https://gyazo.com/598d069f9cde74ad7be51fc2166b5d25
(it auto locks your movement and dir changing in order to not break the animation)
(this could be used for other things probably)
github compare:
https://github.com/goonstation/goonstati...banimation
Posts: 118
Threads: 8
Joined: Jun 2019
BYOND Username: Kak0phony
Character Name: Kjorky Ponkhetz
My god... It's beautiful.....
Posts: 10
Threads: 4
Joined: Feb 2020
BYOND Username: Avatharian
I have gazed upon the face of God
and They have found us wanting.
Posts: 349
Threads: 13
Joined: May 2016
BYOND Username: Triacontakai
Posts: 412
Threads: 12
Joined: Sep 2012
BYOND Username: Hokie/Ines
Character Name: Ines McNabb
Posts: 1,584
Threads: 151
Joined: Jun 2016
BYOND Username: Lady Birb
Character Name: Allie Allison
Posts: 1,400
Threads: 117
Joined: Sep 2016
BYOND Username: Aft2001
YES
OH MY GOD YES
MERGE IT
Posts: 154
Threads: 26
Joined: May 2019
BYOND Username: phyvo
Does it work with mutants? I imagine it could look very bad on lizards/roaches/squidpeople. Otherwise it's great.
Posts: 72
Threads: 15
Joined: Jan 2018
BYOND Username: Moonlol
it uses alpha masks so it will work on all mutant races or should (apart from like martian and monkey probs)
Posts: 154
Threads: 26
Joined: May 2019
BYOND Username: phyvo
Posts: 687
Threads: 43
Joined: Sep 2012
03-09-2020, 09:34 PM
(This post was last modified: 03-09-2020, 09:36 PM by mbc. Edited 1 time in total.)
patch looks good, some notes :
- I don't think we should do `istype() human` checks in input.dm, seems slow and you could just check dir_locked alone i think
- This should probably freeze movement in the same way stuns/buckles do. instead of checking the 'dabbing' flag on /living/Move() and human/restrained(), add some sort of 'emote lock' flag to mobs and check for it in the update_canmove() proc in Life.dm
then you can do this, when you want to freeze/unfreeze movement:
Code:
mob.emote_lock = 1
mob.update_canmove()
[..]
mob.emote_lock = 0
mob.update_canmove()
Posts: 486
Threads: 32
Joined: Jun 2013
BYOND Username: Kovirii
This is the single most amazing thing I have ever laid eyes upon.
Posts: 687
Threads: 43
Joined: Sep 2012
merged w/ suggested fixes
Goonhub
