Goonstation Forums
the small kremfixes thread - Printable Version

+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Patches (https://forum.ss13.co/forumdisplay.php?fid=30)
+---- Forum: Implemented (https://forum.ss13.co/forumdisplay.php?fid=31)
+---- Thread: the small kremfixes thread (/showthread.php?tid=9851)

the small kremfixes thread - kremlin - 01-04-2018

so i dont spam up the forums w/ a new thread for every little thing

goonstation-2016/icons/obj/atmospherics/mixer.dmi icon file is wrong. an arrow is facing the wrong way. this fixes it

[Image: gFH5DVB.png]
^ the middle arrow is facing down when it should be facing up ^

https://ce.gl/mixer.dmi

[Image: mixer.gif]

more 2come

RE: the small kremfixes thread - kremlin - 01-05-2018

another small kremfix for you

thanks to mbc for this fix:

Quote:mbc: ok suggestion kremlin
[9:20 PM] mbc: i'm pretty sure that playsound uses LAGCHECK() somewhere
[9:20 PM] mbc: in other words, it contains a sleep() call
[9:20 PM] kremlin: ahahahah
[9:20 PM] mbc: creating a race condition on P.shooter = shooter
[9:21 PM] kremlin: yeah
[9:21 PM] mbc: so you should move the playsound to the bottom of that proc
[9:21 PM] kremlin: well
[9:21 PM] kremlin: i can sure do that but
[9:21 PM] kremlin: i can't trigger the condition to test anyways
[9:21 PM] mbc: or i mean... we should do that


Code:
diff --git a/code/datums/projectiles/projectile_parent.dm b/code/datums/projectiles/projectile_parent.dm
index a25c9f0..574fc78 100644
--- a/code/datums/projectiles/projectile_parent.dm
+++ b/code/datums/projectiles/projectile_parent.dm
@@ -697,6 +697,8 @@ datum/projectile/snowball

        P.set_loc(S)
        P.proj_data = DATA
+       P.shooter = shooter
+       P.name = DATA.name

        if (narrator_mode)
                playsound(S, 'sound/vox/shoot.ogg', 50, 1)
@@ -715,8 +717,6 @@ datum/projectile/snowball
                P.implanted = DATA.implanted

        P.set_icon()
-       P.shooter = shooter
-       P.name = DATA.name
        P.setMaterial(DATA.material)
        P.power = DATA.power

@@ -777,4 +777,4 @@ datum/projectile/snowball
                Q.mob_shooter = P.shooter
        Q.name = "reflected [Q.name]"
        Q.launch()
-       return Q
\ No newline at end of file
+       return Q

this fixes pods shooting themselves (Maybe)

RE: the small kremfixes thread - Cyfarfod - 01-06-2018

(01-04-2018, 02:37 PM)kremlin Wrote: so i dont spam up the forums w/ a new thread for every little thing

goonstation-2016/icons/obj/atmospherics/mixer.dmi icon file is wrong. an arrow is facing the wrong way. this fixes it

[Image: gFH5DVB.png]
^ the middle arrow is facing down when it should be facing up ^

https://ce.gl/mixer.dmi

[Image: mixer.gif]

more 2come

I powered through this bugging me so much that I think having it FIXED is gonna bug me now. :P

RE: the small kremfixes thread - Mordent - 01-25-2018

Done the first part of this (the mixer sprite). I'm not awake enough to parse whether the second part would actually work, so leaving that for a second.

As an aside, it is absolutely okay to create separate threads for separate things, else you get in a situation like this where some of this has been implemented and some has not.

RE: the small kremfixes thread - ZeWaka - 01-26-2018

(01-25-2018, 06:09 PM)Mordent Wrote: I'm not awake enough to parse whether the second part would actually work, so leaving that for a second.

It was already implemented smile