+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Patches (https://forum.ss13.co/forumdisplay.php?fid=30)
+---- Forum: Rejected (https://forum.ss13.co/forumdisplay.php?fid=33)
+---- Thread: [Refactor] [Boring] Cleanup for clarity (/showthread.php?tid=6708)
[Refactor] [Boring] Cleanup for clarity - Dabir - 07-05-2016
Mostly focused on item.dm but involves a hell of a lot of other files. Lots of proc renaming to make what they do clearer, rearranged the procs in item.dm to be in a relatively logical order, first procs inherited from parents, then its own procs, both sorted alphabetically except that New() is at the start and there's a couple of groups of related procs at the ends of the sections.
E: I fucked it
RE: [Refactor] [Boring] Cleanup for clarity - Noah Buttes - 07-05-2016
Why did you change both attack_self and attack_hand to on_hand_attack?
They don't do the same things.
RE: [Refactor] [Boring] Cleanup for clarity - Dabir - 07-06-2016
I... didn't? Did I say I did? That's wrong. attack_self should have been changed to on_self_use
E: Ah fuck, I did. DISREGARD THIS THEN
RE: [Refactor] [Boring] Cleanup for clarity - Dabir - 07-06-2016
OK I'm pretty sure I didn't fuck it up this time
https://github.com/goonstation/goonstation-2016/compare/master...DabirSA:clarity-cleanup
RE: [Refactor] [Boring] Cleanup for clarity - ZeWaka - 05-31-2017
kinda hard to merge sorry