Goonhub
03-07-2016, 10:06 AM
(This post was last modified: 03-08-2016, 05:57 PM by Isilkor. Edited 1 time in total.
Edit Reason: link to .patch instead of .diff
)
Unlike normal scientists, cyborgs attempting to heat a beaker were presented with a special UI, based on input(). This has several drawbacks: users not familiar with playing borg have to figure out how this new UI works, code is duplicated, and unexpected behaviors emerge. In particular, the old code would allow a human and a cyborg to use the heater at the same time, but not two cyborgs, and cyborgs were unable to change the target temperature or cancel heating/cooling without moving away from the heater.
Moving to a unified UI makes it easier for new cyborg players to quickly figure out what is going on, and resolves some edge cases regarding energy consumption. It also prevents humans and cyborgs from heating one beaker each, which seemed like an oversight to me (especially since it only works if the cyborg starts using the heater before the human inserts a beaker); instead, cyborgs will now insert the beaker into the machine like humans do. Unlike normal beakers, only the cyborg can eject its own beaker; on ejection, the beaker will be removed from the heater but not be spawned on the map - it stays in the cyborg's module at all times. The beaker is also automatically ejected when the cyborg moves away from the heater or is deleted, for example as a result of the chest part breaking.
Branch compare, patch
Moving to a unified UI makes it easier for new cyborg players to quickly figure out what is going on, and resolves some edge cases regarding energy consumption. It also prevents humans and cyborgs from heating one beaker each, which seemed like an oversight to me (especially since it only works if the cyborg starts using the heater before the human inserts a beaker); instead, cyborgs will now insert the beaker into the machine like humans do. Unlike normal beakers, only the cyborg can eject its own beaker; on ejection, the beaker will be removed from the heater but not be spawned on the map - it stays in the cyborg's module at all times. The beaker is also automatically ejected when the cyborg moves away from the heater or is deleted, for example as a result of the chest part breaking.
Branch compare, patch