Goonhub
04-28-2021, 04:34 AM
(This post was last modified: 05-06-2021, 05:16 PM by github_bot. Edited 1 time in total.)
PULL REQUEST DETAILS
[input wanted] [removal]
About the PR
This PR removes dwarfs completely, from both a trait miners can start with and a thing genetics can get in syringe-form. I opted to remove code snippets instead of commenting them out, I figure that if they ever come up, the history is here and easy to find. Or at least to point people to. Don't gotta make the code a museum.
Why's this needed?
Dwarfs are visually broken to the point where 'improve, don't remove' doesn't apply, imo. Not a single jumpsuit or outer suit is fit to them, they *all* look broken, even the stuff miners can *spawn* wearing. We seem to actually care a bit about this game looking good, and I think the dwarfs are pretty far outside 'looks good'.
There are of course, alternatives to removing them that don't make them look *as* broken. Custom fitting all clothing items to them (like monkeys) is completely unfeasible, it's too much work that'll never get done, even if it does, it'll make contributing clothing items more difficult, since you'd have to do two (three if you count monkey!! in the future when they're updated) sprites, which I don't think is worth it. Or that this solution would ever actually realistically be done or maintained.
The other (actually doable) alternative is using some kinda coding solution, like shrinking people's entire sprites down, like stims does or how obesity did before we cut it. While I agree this would certainly be a large improvement over what we have now, I think this would still look really bad and would clash really hard with all the pretty spriteart we've worked so hard on, enough so that I'd still rather have them completely gone than have some code-solution.
I'm aware that some people enjoy dwarfs and don't mind them looking... broken. I don't think having dwarfs is a particularly bad idea at face value, but I *do* mind the broken art, and I think it's just not worth the aesthetic inconsistency to fix. We should have higher standards than that overall for How Things Look, or at least I see it that way. This is very much a specific Design Perspective though.
Changelog
PULL REQUEST DETAILS
[input wanted] [removal]
About the PR
This PR removes dwarfs completely, from both a trait miners can start with and a thing genetics can get in syringe-form. I opted to remove code snippets instead of commenting them out, I figure that if they ever come up, the history is here and easy to find. Or at least to point people to. Don't gotta make the code a museum.
Why's this needed?
Dwarfs are visually broken to the point where 'improve, don't remove' doesn't apply, imo. Not a single jumpsuit or outer suit is fit to them, they *all* look broken, even the stuff miners can *spawn* wearing. We seem to actually care a bit about this game looking good, and I think the dwarfs are pretty far outside 'looks good'.
There are of course, alternatives to removing them that don't make them look *as* broken. Custom fitting all clothing items to them (like monkeys) is completely unfeasible, it's too much work that'll never get done, even if it does, it'll make contributing clothing items more difficult, since you'd have to do two (three if you count monkey!! in the future when they're updated) sprites, which I don't think is worth it. Or that this solution would ever actually realistically be done or maintained.
The other (actually doable) alternative is using some kinda coding solution, like shrinking people's entire sprites down, like stims does or how obesity did before we cut it. While I agree this would certainly be a large improvement over what we have now, I think this would still look really bad and would clash really hard with all the pretty spriteart we've worked so hard on, enough so that I'd still rather have them completely gone than have some code-solution.
I'm aware that some people enjoy dwarfs and don't mind them looking... broken. I don't think having dwarfs is a particularly bad idea at face value, but I *do* mind the broken art, and I think it's just not worth the aesthetic inconsistency to fix. We should have higher standards than that overall for How Things Look, or at least I see it that way. This is very much a specific Design Perspective though.
Changelog
Code:
changelog
(u)Flaborized
(*)Removed dwarfism.PULL REQUEST DETAILS
