Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[PR] Machinery EMP Resistance (Wild Singulo Fixes)
#1
Information 
PULL REQUEST DETAILS



[balance][bug - major][input wanted]
About the PR
* Singularities will no longer attempt to eat things that do not exist. [Bug]
* Limits Camera's to only queue only recalculation when multiple EMPs have happened in the 90 second disable window. [Performance]
* This does make it so you can not add additional delay until the cameras comes back online. [Balance]
* Limits APC battery drain from EMP to once every 90 seconds. [Performance] [Balance]
* Battery drain from EMP can be mitigated by turning off APC due to implementation [Balance]
* Limits EMP on standard machinery to only procing overlay and power drain to once per second.

This does end up being an "unintentional" EMP Grenades, Wave Gun, EMP* nerf as there will be a limit to how often those items can impact /obj/machinery.

----

Addresses a number of runtimes that occur due to spawned tasks having their object disposed of.
Targets performance improvements when multiple EMPs go off to limit the number of new tasks spawned.

Why's this needed?
Runtimes are bad.
Resolve unusual behavior from multiple EMP's going off. Like when the station is covered in singularities...

Code:
(u)Azrun:
(+) Machinery, Cameras, and APCs are more EMP resistant.  Will no longer be able to re-EMPs to reset duration that camera is disabled until it comes back online.


PULL REQUEST DETAILS
#2
Merged/implemented a few hours ago. Mostly a bug-fixing PR, but like the description says, due to the way the fixes are coded, it does make it so turning off APCs makes them immune to battery drain from EMPs and so additional EMPs on an EMP'd camera don't extend how long it's off.

Hopefully, this won't break things like tgui paper have. But do make bug reports if it does and feedback threads if maybe those above shouldn't be.


Forum Jump:


Users browsing this thread: 1 Guest(s)