Trivial orange shoes apparently don't work for rocket shoes

[NateTheSquid]

According to an mhelp convo from Polivilas, orange shoes don't work for making rocket boots, they tried to make rocket shoes with orange shoes and it did nothing, tried with other shoe and it worked. that is all

[Gerhazo]

Confirming the interaction(or rather lack thereof) after personal testing.

[UrsulaMejor]

I wonder if it's because they have their own separate interaction with handcuffs for making shackles? might be a "call your parents" situation

[UrsulaMejor]

Confirmed that this is a "Call your parents" situation.

from code\obj\item\clothing\shoes.dm, here is the code for orange shoes:

Code:

/obj/item/clothing/shoes/orange/attack_self(mob/user as mob)
    if (src.chained)
        src.chained = null
        src.cant_self_remove = 0
        new /obj/item/handcuffs(get_turf(user))
        src.name = "orange shoes"
        src.icon_state = "orange"
        src.desc = "Shoes, now in prisoner orange! Can be made into shackles."
    return

/obj/item/clothing/shoes/orange/attackby(H as obj, loc)
    if (istype(H, /obj/item/handcuffs) && !src.chained)
        qdel(H)
        src.chained = 1
        src.cant_self_remove = 1
        src.name = "shackles"
        src.desc = "Used to restrain prisoners."
        src.icon_state = "orange1"
    return

This bug could easily be fixed by doing the following:

Code:

/obj/item/clothing/shoes/orange/attack_self(mob/user as mob)
    if (src.chained)
        src.chained = null
        src.cant_self_remove = 0
        new /obj/item/handcuffs(get_turf(user))
        src.name = "orange shoes"
        src.icon_state = "orange"
        src.desc = "Shoes, now in prisoner orange! Can be made into shackles."
    ..()
    return

/obj/item/clothing/shoes/orange/attackby(H as obj, loc)
    if (istype(H, /obj/item/handcuffs) && !src.chained)
        qdel(H)
        src.chained = 1
        src.cant_self_remove = 1
        src.name = "shackles"
        src.desc = "Used to restrain prisoners."
        src.icon_state = "orange1"
    ..()
    return

[Firebarrage]