Goonhub
Branch pull request
Department ID Computers thread
To save people running around for the links-
Commit 1 pictures
Commit 2 pictures
Changes are in
code/obj/datacore.dm &
code/obj/machinery/computer/card.dm &
code/obj/machinery/computer/buildandrepair.dm
Commit 1:
- Features ID computers specific to Medical, Research, and Engineering. The head of a given department (or someone with access the department head's office) can grant/remove access for that department. Non-HoP ID Computers only permit changes to access/job/id-colour, but not who the id is registered to. Also they each have their own module card when disassembled.
- Access have been changed to green/red (instead of blue/red).
Commit 2:
- ID computers have a "Fire employee" button. Works by checking the target id against the manifest, then asserting they are hired as a job for the given department (hop counts as all-departments).
If both are true, the user is prompted to give a reason for firing, then the target is set to "Unassigned", their wage is set to 0 (done through the manifest_fire method in datacore.dm), and an announcement is made stating "X was fired for Y".
Regardless of actually 'firing' them, all access specific to the department is removed from the target id.
- Tried to tidy up and shrink the space needed for the window
Todo Summary
- None of the new computers have been added to the maps; the objects can be found in obj/machinery/computer/card near the bottom
Things I noted but didn't fix in the patch:
- Can give an empty firing reason
- Target doesn't need to be next to the machine when giving the reason
- Currently no limit on how frequent firing can occur
- The announcement might be too big, up for debate
- Not sure if firing someone reduces the job assignment count (the one you see when readying at the start), nor if it even should
Seriously this spaghetti code nightmare is a pain to traverse/understand - I bloody love it.
Department ID Computers thread
To save people running around for the links-
Commit 1 pictures
Commit 2 pictures
Changes are in
code/obj/datacore.dm &
code/obj/machinery/computer/card.dm &
code/obj/machinery/computer/buildandrepair.dm
Commit 1:
- Features ID computers specific to Medical, Research, and Engineering. The head of a given department (or someone with access the department head's office) can grant/remove access for that department. Non-HoP ID Computers only permit changes to access/job/id-colour, but not who the id is registered to. Also they each have their own module card when disassembled.
- Access have been changed to green/red (instead of blue/red).
Commit 2:
- ID computers have a "Fire employee" button. Works by checking the target id against the manifest, then asserting they are hired as a job for the given department (hop counts as all-departments).
If both are true, the user is prompted to give a reason for firing, then the target is set to "Unassigned", their wage is set to 0 (done through the manifest_fire method in datacore.dm), and an announcement is made stating "X was fired for Y".
Regardless of actually 'firing' them, all access specific to the department is removed from the target id.
- Tried to tidy up and shrink the space needed for the window
Todo Summary
- None of the new computers have been added to the maps; the objects can be found in obj/machinery/computer/card near the bottom
Things I noted but didn't fix in the patch:
- Can give an empty firing reason
- Target doesn't need to be next to the machine when giving the reason
- Currently no limit on how frequent firing can occur
- The announcement might be too big, up for debate
- Not sure if firing someone reduces the job assignment count (the one you see when readying at the start), nor if it even should
Seriously this spaghetti code nightmare is a pain to traverse/understand - I bloody love it.
