[MERGED PR] New spacelubed floor animation

[github_bot]

PULL REQUEST DETAILS



[BALANCE] [FEEDBACK] [SPRITES]

About the PR
Adds a new animation for lubed floor tiles. This is in response to some discussion when the floor tile resprite went through, and also a previous thread on the forums.

I've modified this quite a bit based on feedback, however there is still a shine animation; this is to give it some visibility over lighter tiles (such as medbay, etc).








(Keep in mind these gifs aren't perfectly timed, so any stuttering/weird timings is probably just where the gif loops, oops)

Why's this needed?
Some players mentioned that lube was hard to see on the new floor tiles, also player feedback in general re: spacelube visibility.

This might not be the right solution to the presented issues [here](https://forum.ss13.co/showthread.php?tid=17421), but I actually started this a couple of weeks ago and figured I'd PR it as an option!

Changelog

Code:

changelog
(u)Walpvrgis
(+)Replaced the spacelubed floor tile effect with new art; should be easier to see on resprited floors now.

PULL REQUEST DETAILS

[walpvrgis]

Also I think Flabo mentioned that lube always appearing as a 2x2 tile square might look strange on floors such as grass or dirt, and I'm not able to fix that rn (this is just a sprite swap and doesn't involve any code), but imo that's not too much of an issue as this is just kind of a representation to let people know the floor has some shenanigans going on. Shrugs!

[KikiMofo]

I think it moves alittle too quickly but other than that I like it

[walpvrgis]

I think it moves alittle too quickly but other than that I like it

I agree, a bunch of other feedback suggests making it less opaque too, so I'll make an updated version later/tomorrow.

[FlamingLily]

It feels a bit too game-y to me, the sprite itself, I mean, while the idea behind it is good, I think as discussed less opaque and slower would be great. A static version might even be better, just as if it were a still shine, and maybe less clear edges so that it looks less custom-fit for the tiles, if you know what I mean

[walpvrgis]

Updated the PR (and gifs above as a result) with a second pass at the animation. Defs let me know what you think.

[KikiMofo]

Yeah I like the new ones much more.

[Merlin1230]

I think it looks great, it might be just a little too obvious on the grey tiles though.

[walpvrgis]

Updated PR again (sorry, animated things always have 34765 revisions ). Azrun made a great code suggestion that applies a blend mode to the animation, making it a bit more subtle, but still readable. I've kept the shine animation for now; it works nicely for floors that the pulse animation isn't that visible on (see images 3 and 4) but I'm not particularly attached to it, so I'm down to remove it if it looks a bit weird still. :P