Posts: 420
Threads: 419
Joined: Aug 2020
01-23-2021, 10:28 PM
(This post was last modified: 01-24-2021, 07:10 PM by github_bot. Edited 4 times in total.)
PULL REQUEST DETAILS
[BALANCE] [INPUT]
About the PR
This PR changes armory authorization to require security locker access, as opposed to regular security access. It also removes security locker access from vice officers. This means lawyers, vice officers, and detectives (and security assistants once they're merged) cannot participate in armory authorization, as they do not have the required access.
Why's this needed?
I think it's good if only the HoS and "full" members of security have the ability to authorize the armory open.
Changelog
Code:
(u)Flourish:
(*)Authorizing the armory open now requires security equipment access (the access you need to open security lockers) as opposed to regular security access. This means lawyers, vice officers, and detectives can no longer help authorize it open.
(+)Vice officers no longer have security equipment access.
Posts: 466
Threads: 16
Joined: Aug 2020
BYOND Username: Nefarious6th
please. im tired of detectives and whatever staffies the captain throws at us and lawyers authing armory.
Posts: 277
Threads: 28
Joined: Feb 2018
BYOND Username: Spoodle
Character Name: Sylvian Stone, Tony Williamson, Jenna Sekwa
Of course I could always be missing something, but I see no downsides. +1 from me
Posts: 3,074
Threads: 272
Joined: Dec 2012
Posts: 397
Threads: 38
Joined: Sep 2012
BYOND Username: Sord213
Posts: 465
Threads: 11
Joined: Nov 2019
BYOND Username: Leeanei
had no idea that the lawyer horde could open the armory. This is a very good change.
Posts: 413
Threads: 13
Joined: Aug 2020
BYOND Username: Roselace
Character Name: Loki Nim (LRP/RP) / Bumplestein Jumbalaya (LRP overflow)
A bit sad the det can't authorise anymore, in my limited experience the ones that do armory authorisation tend to be pretty involved as sec.
Posts: 1,357
Threads: 160
Joined: Sep 2012
01-24-2021, 04:33 PM
(This post was last modified: 01-24-2021, 04:36 PM by kyle2143. Edited 1 time in total.)
Yes, good. Finally flourish does something good instead of evil. I hope it doesn't change her alignment.
Posts: 2,649
Threads: 33
Joined: Nov 2013
BYOND Username: KikiMofo
Seems about right. If the detective can't open a security locker than they shouldnt be authoritizing armory. Of course this doesnt stop the captain/HoP from making multiple security IDs and authing the armory that way.
Posts: 1,584
Threads: 151
Joined: Jun 2016
BYOND Username: Lady Birb
Character Name: Allie Allison
(01-24-2021, 05:25 PM)KikiMofo Wrote: Seems about right. If the detective can't open a security locker than they shouldnt be authoritizing armory. Of course this doesnt stop the captain/HoP from making multiple security IDs and authing the armory that way.
imo only the HoS should be able to give IDs sec access but that is a discussion for another thread.
Posts: 193
Threads: 16
Joined: Jun 2020
BYOND Username: boxta
Character Name: box ta
(01-24-2021, 05:25 PM)KikiMofo Wrote: Seems about right. If the detective can't open a security locker than they shouldnt be authoritizing armory. Of course this doesnt stop the captain/HoP from making multiple security IDs and authing the armory that way.
IIRC Armory auth checked fingerprint and ID, so you'd have to swap out for a new arm every time
Posts: 2,649
Threads: 33
Joined: Nov 2013
BYOND Username: KikiMofo
(01-24-2021, 05:40 PM)Boxta Wrote: (01-24-2021, 05:25 PM)KikiMofo Wrote: Seems about right. If the detective can't open a security locker than they shouldnt be authoritizing armory. Of course this doesnt stop the captain/HoP from making multiple security IDs and authing the armory that way.
IIRC Armory auth checked fingerprint and ID, so you'd have to swap out for a new arm every time
I mean the captain/HoP could just give two ids to some other grey suits to auth it but yeah its more trouble
Goonhub
