[MERGED PR] Cloning rack

[Drakios]

like this new cloning system, but I wish the cloning racks had more space for disks, you run out pretty much at minute 5 for space, and then you have to wait for engi to scan and build more, which sure makes it so departments have to work more together, but I think after a while this would just get annoying to deal with.
Also some sort of function to make it so that if a person cant be cloned do to DNR that it would be visible? I guess you can just write it on the disk, but maybe also an extra function to make the light turn off so people dont just always walk in no matter what department they are from and try to clone a person who is DNR because they saw the funny red light

[Frank_Stein]

Maybe everyone should start off with a disk containing their DNA already in their inventory, similar to Sec? (Unless they opt out with a trait or something) You don't have to get scanned, but you do have to make arrangements for it to get to Genetics and for them to manage that for you.
Maybe you hide your disk under the floor somewhere, maybe you mail it to genetics, maybe you leave it with a friend or bribe someone to take it to them in the case of death. If you ever lose your disk, they can of course scan you to upload to a new disk.

Maybe the disks act as a kind of authentication system, and you can have more DNA locked devices and mechanics around the station, where you need a copy of the disk inserted somewhere else to be added to a whitelist. The Captain's authentication disk just becomes a disk with their DNA saved on it

[witchkit]

Maybe everyone should start off with a disk containing their DNA already in their inventory, similar to Sec?

current issue with this is that sec's roundstart disks read them as dead, probably cuz they lack a cloning implant to track the heartbeats from. but then if you give everyone a cloning implant at roundstart you might have conflicts with puritans and stuff? idk. not sure how that fix would work, but felt like it was worth mentioning w/rt your idea

---

so ive been watching/playing a good few rounds with this and i have a few thoughts to share

for starters, i DO think its a very cool idea in concept and overall seems to be a good nerf to cloning. im glad we also got the recent update w/ two racks per tile (and 2 racks for roundstart). i think it would also be worth making more disks available at roundstart (maybe having another box or two available in the storage closet thats usually in cloning)

theres been a good few bugs that have been/im sure will be addressed and fixed. the thing with the changeling DNA was stated to be intentional, but i feel like it too easily gives away that there is a changeling and who it is. not sure how others feel about it, but i guess lings could also just not get a scan of their own and also be careful about eating people with scans

i think my main gripes with the PR overall is just the clunkiness of managing disks. the addition of a 2nd rack i think will help a lot with demand at roundstart, so im less worried about that, but the situation of running out of disks can still be pretty annoying. as mentioned previously, i'd say its probably worth providing another box or two of disks in cloning (in the locker). also, it might be worth making a full box printable from the medical fabricator. materials might still be a bit of a problem, but honestly, the disks only take metal and conductive so... not too hard to snag some from warehouses/storage (or wait until mining gets stuff in). some people have mentioned concerns about running out of materials too fast and whining towards mining to hurry up and get more in, but i honestly dont think the cost of printing more disks is too high that you run out too fast (assuming docs arent printing too many implants and tools). again, i think providing extra disks at roundstart would also help with these kinds of concerns.

any other issues i had mostly seem to be related to bugs that im sure will be worked on or have already been addressed like number of roundstart racks. id say the only other concern i have is just the fact that the racks take up precious space in an area that is often already pretty cramped. buuut i think the double racks on one tile thing should help a good amount.

one other thing i think someone else mentioned is that placing a rack in front of a light will block the bottom 1 or 2 disk's lights if they're flashing. idk if that can be changed so that the flash shows through the light or not. i figure its the kind of thing thats going to be ran into even aside from maps where the roundstart rack has been placed in such a spot, as ive seen extra racks placed in these spots, too. i'd suggest maybe still rethinking where to place the roundstart ones that are blocked, though (only one i know if atm is donut 2).

[LeahTheTech]

Okay changes made from feedback/bug reports:
- There are now two racks roundstart and two racks can be placed on the same tile when built from a mechscan
- A cloning rack frame has been added to the cargo cloning kit
- Jobs that spawn with a clone disk now also spawn with a cloner implant that reports their scanned location as "NT Reconstitution Center" (may or may not be a real area you can visit in-game)

[meaow589]

i like the idea that allow to use clone disk more. for main reason is if the player is dead or cloner dead we still have the disk to clone them back anytime. also traitor with clone hack can steal the disk and clone hacke easier. anyway some downside also have it add more step to use that might effect step in cloning. im fine with this PR

[xenomni]

I was chatting about this with a pal and decided to go ahead and spit these thoughts here. Basically one of the biggest nerfs here is borgs and ai can no longer do cloning. Period. I think this is a huge shame. Understandable if that's part of the purpose, but what ended up being discussed and may be a good suggestion is adjusting the cyborg medical module to have a 'disk holder' item. Basically just... a hand that can ONLY pick up and insert disks. 

Having it tied to the medical module would mean cyborgs can still interact with the cloning system at the very least with a specific module- like how the mining module has the barcode scanner or the research module has artifact analysis forms. 

Other things to consider is how cryo reads disks. Perhaps a specific color for a cryo person- as far as I know if someone enters cryo permanently it marks them as dead on the disk. Not sure how it works for temp cryo.

[Torchwick]

Haven't had much chance to mess with the PR myself, but chiming in to say; I totally forgot silicons would be unable to clone with this. I agree with Xenomni -- they should probably be able to at least click drag a disk into the cloner, sort of like how they can drag modules out of the module rewriter. This means they still wouldn't be able to shove a body into the cloner like normal, but they could still hit the clone button on records if required, which can be a huge help.

[LeahTheTech]

Perma cryo and AI issues fixed!
As for the borg thing, in my experience most of mediborg interaction with the cloner is dragging a body over and going "can someone with hands deal with this pls" so I don't think them not being able to interact with disks changes much? I'm generally against just adding specialist hands for minor things borgs can't do, although it might be cool if borgs could install an actual floppy drive somehow :P

[Torchwick]

Perma cryo and AI issues fixed!
As for the borg thing, in my experience most of mediborg interaction with the cloner is dragging a body over and going "can someone with hands deal with this pls" so I don't think them not being able to interact with disks changes much? I'm generally against just adding specialist hands for minor things borgs can't do, although it might be cool if borgs could install an actual floppy drive somehow :P

It doesn't change much for an initial scan, but now they can't clone a record if they're dead. It may not be as big of an issue on highpop, but low-mid pop borgs being able to press the clone button for someone already scanned in and dead was always a huge help.

[Calphrick]

Borgs are now even more helpless when it comes to cloning, great. Also there are way too few disk spots on the rack

[xenomni]

Perma cryo and AI issues fixed!
As for the borg thing, in my experience most of mediborg interaction with the cloner is dragging a body over and going "can someone with hands deal with this pls" so I don't think them not being able to interact with disks changes much? I'm generally against just adding specialist hands for minor things borgs can't do, although it might be cool if borgs could install an actual floppy drive somehow :P

 
Basically what torchwick said. The thing is borgs DO have specialist things in specialist modules like I mentioned. Artifact analysis forms are just... built in hand that holds and places the analysis form. Barcode scanner when you go down to it is a replacement hand that holds barcodes. Tongs are hands that interact with food. I don't see why a disk holder for medical module specifically would be different from the above lists and their modules. 

For lowpop in particular a lot of the time cyborgs end up being the designated medical personnel because there is none. The thing about scanning a body and cloning someone who got scanned is that getting prescanned before meant you didn't have to rely on someone with hands- even the ai could clone you and that rewarded your forward thinking. Now if only silicons are around in medbay while theres either no other medical staff or are out dealing with a threat/healing those dealing with it that are alive, getting clonescanned wont help because they cannot clone you anymore, its basically the same as being a random corpse that got dragged in if that makes sense?

[Piesuu]

Honestly? Silicons should have a built-in terminal they can put floppies in (+ moving them around to different storages via dragging) :p
Or just mediborgs with a floppy arm!

[JORJ949]

I'd like to point out that the goal of the PR is to limit prescanning as "going for your morning scan" can be extremely annoying as antagonist when you escalate to the point of killing someone and not even 3 seconds later they're barking down the radio about how evil you are because they got a clonescan at the immediate start of the shift. This is especially bad as ling/vampire/mindhack cloner, I've killed someone and they've been cloned before I could despite killing them in the listening post right next to my evil cloner.

[xenomni]

I'd like to point out that the goal of the PR is to limit prescanning as "going for your morning scan" can be extremely annoying as antagonist when you escalate to the point of killing someone and not even 3 seconds later they're barking down the radio about how evil you are because they got a clonescan at the immediate start of the shift. This is especially bad as ling/vampire/mindhack cloner, I've killed someone and they've been cloned before I could despite killing them in the listening post right next to my evil cloner.

i really dont think this pr is going to help with this particular situation. i think the issue with cloning and memory in rp is that its nebulous and goon doesnt use metashield like other servers. its more up to the discretion of the player themself how much they want to reveal.

[Cropsey]

A reasonably unobtrusive change to help borgs out here would be to let them open/close/deploy body bags, which if I'm not mistaken slow down rotting? If they don't, giving them more access to embalming fluid should help. There isn't a whole lot of it in the morgue and it's not *that* easy to make.