Goonhub
06-09-2021, 09:16 AM
(This post was last modified: 06-12-2021, 08:34 PM by github_bot. Edited 3 times in total.)
PULL REQUEST DETAILS
[CLEANLINESS] [INPUT WANTED] [QOL]
About the PR
This is an attempt to make some of the antag, (mostly traitor), objectives a bit more clear on what is required to succeed with them. It also cleans up a tiny bit of code because the linter, (or whatever it's called), was complaining about it.
Why's this needed?
Resolves #4209 at least partly mainly regarding the issue of some of the objective descriptions possibly being a bit vague. This was also an attempt into looking for the errors mentioned but I haven't been able to replicate them after a few tries with testing especially with the aforementioned the staying alive at rounds end and stealing a horse head. Both still worked even with a bloody cursed monkey horse head equipped and a bloody regular horse head stuck in the player's backpack and inside the box inside the backpack.
Line change sum-up
- **Regular Assassinate:** Mentioned that the objective doesn't count if the target gets revived unless they are revived as a cyborg/AI.
- **Regular Steal:** Mentioned that it counts as long as they have the item _anywhere_ on their person at round end.
- **Regular Multigrab:** Same deal except that the stealing hearts objective is clarified to mean actual hearts.
- **Escape Hijack:** Clarified that if someone does get onto the shuttle with them, it will still count if that person is dead before they reach Centcom.
- **Escape Survive:** Explained that they just have to stay alive anywhere, station or otherwise.
- **Escape Rescue:** Mentioned that the target has to actually be alive and not a cyborg at Centcom.
- **Escape Hijack_Group:** Same deal as regular hijack.
Changelog
PULL REQUEST DETAILS
[CLEANLINESS] [INPUT WANTED] [QOL]
About the PR
This is an attempt to make some of the antag, (mostly traitor), objectives a bit more clear on what is required to succeed with them. It also cleans up a tiny bit of code because the linter, (or whatever it's called), was complaining about it.
Why's this needed?
Resolves #4209 at least partly mainly regarding the issue of some of the objective descriptions possibly being a bit vague. This was also an attempt into looking for the errors mentioned but I haven't been able to replicate them after a few tries with testing especially with the aforementioned the staying alive at rounds end and stealing a horse head. Both still worked even with a bloody cursed monkey horse head equipped and a bloody regular horse head stuck in the player's backpack and inside the box inside the backpack.
Line change sum-up
- **Regular Assassinate:** Mentioned that the objective doesn't count if the target gets revived unless they are revived as a cyborg/AI.
- **Regular Steal:** Mentioned that it counts as long as they have the item _anywhere_ on their person at round end.
- **Regular Multigrab:** Same deal except that the stealing hearts objective is clarified to mean actual hearts.
- **Escape Hijack:** Clarified that if someone does get onto the shuttle with them, it will still count if that person is dead before they reach Centcom.
- **Escape Survive:** Explained that they just have to stay alive anywhere, station or otherwise.
- **Escape Rescue:** Mentioned that the target has to actually be alive and not a cyborg at Centcom.
- **Escape Hijack_Group:** Same deal as regular hijack.
Changelog
Code:
changelog
(u)eX.n0x
(+)Reworded some traitor objectives for clarity.PULL REQUEST DETAILS