Goonhub
09-07-2016, 10:19 PM
Re: Mordent
It's a .txt on a commonly used upload site, if you are really that paranoid open it up in a sandbox on a virtual machine that logs everything.
That's all I really see without looking at how the code works, I just looked at it overall. Feeding it into a DM compiler next time would help eliminate almost all of the above.
It's a .txt on a commonly used upload site, if you are really that paranoid open it up in a sandbox on a virtual machine that logs everything.
- Mixing tabs and spaces.
tabz r the best
- Because of that, you also have inconsistent indentation in the code. You have things indented when you should not have them, see predatorblast:51
- Our ability code does not really look like this, unless you meant "/datum/targetable/" instead of "/datum/abilities/"
- Because of that, you will get numerous errors when you compile since there is no parent type for it to inherit these variables from.
- If it was switched, you would get the error "warning: MT.name: use of MT precedes its definition" because you define MT at :51 but you are referencing it at :48. You need to define your variable before you can operate on it.
- This would be a much better fit for the projectile system, wth the spell just calling it and feeding it the target and owner. See fireball.dm
That's all I really see without looking at how the code works, I just looked at it overall. Feeding it into a DM compiler next time would help eliminate almost all of the above.