Goonstation Forums › Discussion › Patches › Implemented
[Feature] Security HUD

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Linear Mode
[Feature] Security HUD
Erik Offline

Posts: 770
Threads: 157
Joined: Jul 2015
BYOND Username: ErikHanson
#3
07-04-2016, 10:36 AM
Yes! I recall you posting about this in IRC, the code looks alright but i do have some suggestions if you don't mind!

  • You are updating the icon_state for the arrestIcon each Life() tick, I'd suggest checking for changes first, and then updating the icon_state only when there are changes to prevent appearance churn.
  • I would suggest not using the colon operator to seek variables, you could easily replace that with a istype(variable, path)  and then typecast.
  • I would suggest changing the if(contrabandLevel) to if(contrabandLevel > 0)
Find
Reply


Messages In This Thread
[Feature] Security HUD - by Grayshift - 07-04-2016, 08:54 AM
RE: [Feature] Security HUD - by Noah Buttes - 07-04-2016, 10:28 AM
RE: [Feature] Security HUD - by Erik - 07-04-2016, 10:36 AM
RE: [Feature] Security HUD - by Frank_Stein - 07-04-2016, 10:38 AM
RE: [Feature] Security HUD - by Noah Buttes - 07-04-2016, 11:15 AM
RE: [Feature] Security HUD - by atomic1fire - 07-06-2016, 01:30 PM
RE: [Feature] Security HUD - by Frank_Stein - 07-04-2016, 11:24 AM
RE: [Feature] Security HUD - by Noah Buttes - 07-04-2016, 11:26 AM
RE: [Feature] Security HUD - by Grayshift - 07-05-2016, 03:38 PM
RE: [Feature] Security HUD - by Erik - 07-06-2016, 08:56 AM
RE: [Feature] Security HUD - by Noah Buttes - 07-06-2016, 09:14 AM
RE: [Feature] Security HUD - by Dabir - 07-06-2016, 01:39 PM
RE: [Feature] Security HUD - by Wire - 07-08-2016, 09:29 AM

Forum Jump:


Users browsing this thread: 1 Guest(s)