[PR] Forensics Rewrite

[LorrMaster]

if i understand how this would work and what it'd apply to, for example, a phaser gets marked as fabricated versus imported, you know that it's in the ruck kit and can lock it ASAP versus someone picked it up from the debris field or cargo was having a good day.

Yes, that is exactly the case. I think it makes sense that security would be able to figure out the origin of an item if they wanted to based on whatever structure or residue is left behind. Maybe later on down the road someone could lock that behind a "deep forensic scan" of some sort so that security doesn't get that information without specifically looking for it. I think it would make more sense for antags to be able to disconnect a ruck kit from the rest of the station or find a more roundabout way of importing equipment for when security wises up.

also not 100% on the retina scans but that's just personal flavor and i don't have any meaningful reason of why that would help guide the implementation or anything.

I don't think that retina scans are likely to come up in a typical round, but there is a small chance that they could which is why I personally like them. I also didn't mention that most types of eyes generate different types of IDs. So an experienced detective might be able to tell the difference between the ID of a normal eye, a robotic eye, a cow eye, a secHUD eye, and a laser eye.

love the timestamps, broadly think the footprint/organ matching for sets could be cool in some cases, and the glove masking here is way better than current.

One thing I am worried about with glove masks is where the balance might be in how much of the base print to reveal. One character isn't useful unless if you know where it is, three or even two characters might be enough to give it away. Need to do some math here to get it right.