[PR] Forensics Rewrite

[LorrMaster]

How is it assigning prints to people? Is it directly using SECMATE data to do that or is it being manually entered by the person collecting evidence? Both are fine, but might have interesting interactions with someone fudging/deleting secmate records later on. If it's automatically updating the sudden change of names tied to evidence might be a big hint. I don't think this is a bad thing, you could frankly do the same right now with your personal notes/notepad when you cross-reference it. I'm more asking out of curiosity.

I haven't even touched security records yet, so that implementation is still up in the air. It's important to note that evidence is divided into two parts. The first is "forensic_data", which represents all the data tied to a specific event. Such as an individual piece of DNA evidence, which would have a *reference* to a DNA ID along with whether it is blood, hair, tissue, etc. A specific fingerprint would have a reference to the fingerprint ID + a reference to the ID of the glove that the person was wearing (+ information on how the fp should be masked). The second part is the ID itself which is the "forensic_id" datum. This is created by whatever object it is attached to via a proc meant to create that kind of ID. The ID text is just there for the player, it is really the datum reference to that ID that the code cares about.

So an eye will have a "forensic_id" variable, which will usually either reference a "default_retina_id" of a bioholder or be created by the eye itself if that is not applicable. A person has two eyes, so living mobs have a proc that will check a person's eyes at that time and returns a datum that pairs them both together. A doctor may then perform a scan with their health analyzer, which will create a new datum that holds a reference to the IDs of the targets eyes and the ID of their DNA at that moment (changing a person's DNA later on requires that a new ID value be created, since all the previous pieces of data evidence assume that their existing ID will not change). Let me know if that explanation makes sense.

The safe combo thing, is that currently a thing anywhere else? If not, it seems a little odd to include. I appreciate it has some fun forensic flavour to it but reducing the safe cracker game to three characters over four might want to be watched during its implementation. It might not make any kind of crazy difference at all, but I'm just trying to scrutinize things here.

The safe combo thing is mostly just there to show that objects can add their own text to a forensics scan outside of the normal forensics system. So a bell could have a counter for the number of times it's been rung and then display that number if someone performs a forensics scan on it. Mobs show how much ethanol is currently in their bloodstream in the same way. It's less a feature of the forensics system itself and more that since a report is just text, you can just throw in whatever else you want into them. Hints for safe cracking could require forensics training using a single if statement, for example.