Goonhub
01-16-2023, 09:47 PM
(This post was last modified: 02-08-2023, 12:00 PM by github_bot. Edited 1 time in total.)
PULL REQUEST DETAILS
[INPUT][RP][FEATURE]
About the PR
This PR may be controversial, please allow adequate time for feedback. This PR also does not in any way constitute an endorsement or repudiation of the current or past state of affairs regarding observer respawns.
Reverts commit [93bee53](https://github.com/goonstation/goonstati...d3922cb1cf) and the other changes made to `observer.dm` to allow the game to compile properly. Choosing to observe the round will allow respawns after the standard respawn time when `RP_MODE` is true.
When choosing to observe from the splash screen, the pop-up will inform the player that they have the option to participate when their respawn timer runs out.
![[Image: 212818488-08458960-59d9-490d-96cb-7a4bdabc44d2.png]](https://user-images.githubusercontent.com/66253095/212818488-08458960-59d9-490d-96cb-7a4bdabc44d2.png)
Why's this needed?
For a long time, the continued inclusion of this feature/bug didn't seem to garner a consensus among the development team and was generally left alone until #12750 prompted a change. This change has been met with some level of controversy, and this PR attempts to present another option for retaining that feature while also making it explicit that it _is_ a feature.
On RP, ghosts who have participated in the round and either die or cryo are already permitted to respawn after a timer. It may be incongruent to disallow respawns from ghosts who choose to observe the round from the outset, and the rules are already explicit on respawning players and metagaming.
Changelog
PULL REQUEST DETAILS
[INPUT][RP][FEATURE]
About the PR
This PR may be controversial, please allow adequate time for feedback. This PR also does not in any way constitute an endorsement or repudiation of the current or past state of affairs regarding observer respawns.
Reverts commit [93bee53](https://github.com/goonstation/goonstati...d3922cb1cf) and the other changes made to `observer.dm` to allow the game to compile properly. Choosing to observe the round will allow respawns after the standard respawn time when `RP_MODE` is true.
When choosing to observe from the splash screen, the pop-up will inform the player that they have the option to participate when their respawn timer runs out.
Why's this needed?
For a long time, the continued inclusion of this feature/bug didn't seem to garner a consensus among the development team and was generally left alone until #12750 prompted a change. This change has been met with some level of controversy, and this PR attempts to present another option for retaining that feature while also making it explicit that it _is_ a feature.
On RP, ghosts who have participated in the round and either die or cryo are already permitted to respawn after a timer. It may be incongruent to disallow respawns from ghosts who choose to observe the round from the outset, and the rules are already explicit on respawning players and metagaming.
Changelog
Code:
changelog
(u)DisturbHerb
(*)Observer respawn has been re-implemented for the roleplay servers. The pop-up will explicitly inform you that you are unable to participate until the respawn timer runs out. Please do not use this to metagame.PULL REQUEST DETAILS