Goonhub
02-09-2021, 03:10 PM
(This post was last modified: 02-09-2021, 03:10 PM by Studenterhue. Edited 1 time in total.)
Personally, I second MBC's suggestion. Don't need to have picking up replace the suplex, grab-throw, and other grab-intent interactions for ghost critters.
I don't see much of a reason to bring up an pull request that has already been closed. The "pick up and eat critters" PR has already been rejected for many other reasons: too big for the intended goal of making lizards able to eat dead critters, there are much simpler ways to add said ability, kinda unintuitive, creates a huge "design debt" to cover the possible interactions between grabs and critters that hasn't been fulfilled (youch, you eat a pikalia and your mouth is a macerated! ow, I picked up a snake and it almost bit me!), and generally kinda messy. I'm of MarkNStein's mindset about the matter; to me, this is less an older PR split into smaller ones and more a refinement occurring in piecemeal, though further criticism is valid. Simply put, I don't think "pick up and eat critters" is going to happen, and I don't think this PR is trying to go down that path.
I don't see much of a reason to bring up an pull request that has already been closed. The "pick up and eat critters" PR has already been rejected for many other reasons: too big for the intended goal of making lizards able to eat dead critters, there are much simpler ways to add said ability, kinda unintuitive, creates a huge "design debt" to cover the possible interactions between grabs and critters that hasn't been fulfilled (youch, you eat a pikalia and your mouth is a macerated! ow, I picked up a snake and it almost bit me!), and generally kinda messy. I'm of MarkNStein's mindset about the matter; to me, this is less an older PR split into smaller ones and more a refinement occurring in piecemeal, though further criticism is valid. Simply put, I don't think "pick up and eat critters" is going to happen, and I don't think this PR is trying to go down that path.