10-10-2019, 10:19 PM
(This post was last modified: 10-10-2019, 10:27 PM by UrsulaMejor. Edited 2 times in total.)
I'm pretty sure that staplers already do stand in for staple guns...
Like...
I'm pretty sure that the staplers are literally just staple guns with a different sprite.
At least, that's how it used to be!
This is a bug.
surgery checks for:
this should be:
The intent clearly was to have red staplers work for surgery, as staplers used to literally just be staple guns with a manually edited sprite on the map:
My guess is that some coder decided that office closets should probably contain regular staplers instead of stapleguns like they used to:
and made a child object; probably /obj/item/staple_gun/red
and since the surgery tool check does .type == instead of istype()... whatever coder did this broke office supply surgery.
Like...
I'm pretty sure that the staplers are literally just staple guns with a different sprite.
At least, that's how it used to be!
This is a bug.
surgery checks for:
Code:
surgery(var/obj/item/tool)
if(remove_stage > 1 && tool.type == /obj/item/staple_gun)
remove_stage = 0
this should be:
Code:
surgery(var/obj/item/tool)
if(remove_stage > 1 && istype(tool,/obj/item/staple_gun))
remove_stage = 0
The intent clearly was to have red staplers work for surgery, as staplers used to literally just be staple guns with a manually edited sprite on the map:
Code:
/obj/item/staple_gun{desc = "A red stapler. No, not THAT red stapler."; icon = 'icons/obj/items.dmi'; icon_state = "stapler"; item_state = "stapler"; layer = 7; name = "stapler"}
My guess is that some coder decided that office closets should probably contain regular staplers instead of stapleguns like they used to:
Code:
/obj/storage/closet/office
name = "office supply closet"
desc = "Various supplies for the modern office."
make_my_stuff()
..()
[SNIP]
var/obj/item/staple_gun/B6 = new /obj/item/staple_gun(src)
B6.pixel_y = -5
B6.pixel_x = -4
and made a child object; probably /obj/item/staple_gun/red
and since the surgery tool check does .type == instead of istype()... whatever coder did this broke office supply surgery.