Goonhub
02-20-2019, 12:25 AM
(This post was last modified: 02-20-2019, 01:44 PM by kyle2143. Edited 3 times in total.)
Updated:
It occurred to me to test if pulling an item off of the tray with the pull verb might break my change. And it does, so I decided to fix it. My fix for this also fixes the commonly experienced bug where you can use the pull-click to pull mobs or items out of the morgue or genetics scanners. Sorry. I thought about not fixing it and just making it so that you can pull items off the tray, but that would mean making 3 changes to turf.dm for a single object's special use. Much better to make 3 changes to fix a bug, even if some people use it for fun.
Basically I just added a check for if the object being pull-clicked's loc is an object and if they're in that object's contents. This is in turf/simulated, turf/unsimulated, and turf/space. You'll need to add it to turf/oshan_floor or whatever itc called. I suppose I am redundantly checking to see if the pulled object is in the container object's contents. But I didn't know or care enough to say if there's an edge case so better safe than sorry...
https://github.com/goonstation/goonstati...efd983d89d
Edit: Fixed that original bug with the throwing at objects. Had to add a check in proc/throw_at . You can take or leave it, it's only in the very last commit: https://github.com/goonstation/goonstati...6bf1976f8b
It occurred to me to test if pulling an item off of the tray with the pull verb might break my change. And it does, so I decided to fix it. My fix for this also fixes the commonly experienced bug where you can use the pull-click to pull mobs or items out of the morgue or genetics scanners. Sorry. I thought about not fixing it and just making it so that you can pull items off the tray, but that would mean making 3 changes to turf.dm for a single object's special use. Much better to make 3 changes to fix a bug, even if some people use it for fun.
Basically I just added a check for if the object being pull-clicked's loc is an object and if they're in that object's contents. This is in turf/simulated, turf/unsimulated, and turf/space. You'll need to add it to turf/oshan_floor or whatever itc called. I suppose I am redundantly checking to see if the pulled object is in the container object's contents. But I didn't know or care enough to say if there's an edge case so better safe than sorry...
https://github.com/goonstation/goonstati...efd983d89d
Edit: Fixed that original bug with the throwing at objects. Had to add a check in proc/throw_at . You can take or leave it, it's only in the very last commit: https://github.com/goonstation/goonstati...6bf1976f8b