[Feature] Restocking Vending machines

[Noah Buttes]

I don't think the all-purpose refill unit would be compatible with any vending machine right now since you don't have any code to handle the special situation where W:vendingType is "all".

Also, just a suggestion based on what I've been told and have experienced while making patches.

You might want to change

Code:

    if (istype(W, /obj/item/vending/restock_cartridge))
        //check if cartridge type matches the vending machine
        if (istype(src, text2path("/obj/machinery/vending/[W:vendingType]")))

to something like

Code:

    if (istype(W, /obj/item/vending/restock_cartridge))
        //check if cartridge type matches the vending machine
        var/obj/item/vending/restock_cartridge/Q = W
        if (istype(src, text2path("/obj/machinery/vending/[Q.vendingType]")))

Or something along those lines.

In general, avoid using : unless you absolutely have to.