Goonhub
11-29-2017, 05:08 PM
(This post was last modified: 11-29-2017, 09:10 PM by Dieting Hippo. Edited 4 times in total.)
I'll be home in an hour or two to investigate this more on the 510 branch. In the meantime I want to get more information so I can see if I can diagnose what's going wrong. Post-deploy bugs are the best bugs 
Die falling out on use: I will look into this. When I was testing on 510 I had used a d100 and the die stayed in the chest displaying results. Was the die sutured into place, and what die had you used for this? Edit: This is due to weird die behavior. Dice are coded to always appear on the ground when rolled, and activations by chest hit don't stop that. This is working as intended.
Farting does not activate item: I'll have to look into that more. The last I had seen before submitting it was working, but I'll have to try doing more egg-assisted testing on NPCs. Edit: Was your butt attached when you tried this? If you have no butt you can't fart, and if you can't fart you can't fart-activate things or poop them out. This is something I wasn't able to repro on the 510 branch, but if you have more details that'd be awesome. This may have also been caused by another bug I found where you couldn't fart out any items ever again after one had been sewn in.
Medkit teleportation: This was done with self surgery, which may have different implications during the surgery process regarding where the item is placed. Will do more investigating later, if I can dupe it but can't fix it I'll have to disallow crates. Edit: I wasn't able to repro this on the 510 branch with self surgery. I'll have to try to repro on the live server later.
AH FUCK PIPEBOMB: This could either be bleed damage from surgery triggering item activation or the suture use on the patient triggering this. If it's the latter then that'll be a simple surgery check to prevent errant medical explosions. Edit: This is fixed. There is now a check to see if surgery is being performed. If not, the item activates.
Edit: I fixed one more bug I found where cutting an item out of someone's chest with a scalpel would not reset the chest_item_sewn flag. This meant that if one item was ever sewn in, all future items would always be sewn in. The flag now resets when you cut out an item, fart away!
Die falling out on use: I will look into this. When I was testing on 510 I had used a d100 and the die stayed in the chest displaying results. Was the die sutured into place, and what die had you used for this? Edit: This is due to weird die behavior. Dice are coded to always appear on the ground when rolled, and activations by chest hit don't stop that. This is working as intended.
Farting does not activate item: I'll have to look into that more. The last I had seen before submitting it was working, but I'll have to try doing more egg-assisted testing on NPCs. Edit: Was your butt attached when you tried this? If you have no butt you can't fart, and if you can't fart you can't fart-activate things or poop them out. This is something I wasn't able to repro on the 510 branch, but if you have more details that'd be awesome. This may have also been caused by another bug I found where you couldn't fart out any items ever again after one had been sewn in.
Medkit teleportation: This was done with self surgery, which may have different implications during the surgery process regarding where the item is placed. Will do more investigating later, if I can dupe it but can't fix it I'll have to disallow crates. Edit: I wasn't able to repro this on the 510 branch with self surgery. I'll have to try to repro on the live server later.
AH FUCK PIPEBOMB: This could either be bleed damage from surgery triggering item activation or the suture use on the patient triggering this. If it's the latter then that'll be a simple surgery check to prevent errant medical explosions. Edit: This is fixed. There is now a check to see if surgery is being performed. If not, the item activates.
Edit: I fixed one more bug I found where cutting an item out of someone's chest with a scalpel would not reset the chest_item_sewn flag. This meant that if one item was ever sewn in, all future items would always be sewn in. The flag now resets when you cut out an item, fart away!