Posts: 19
Threads: 1
Joined: Oct 2021
BYOND Username: Egregorious
Character Name: Egryg Reus
06-18-2024, 04:27 AM
(This post was last modified: 06-18-2024, 04:33 AM by Egregorious. Edited 1 time in total.)
Rancher and Mail Courier uniforms currently aren't available in the Chameleon Outfit's menu.
I also personally feel like many of the gimmick job outfits should be options too, but at least all the regular jobs should be included.
Posts: 475
Threads: 84
Joined: Mar 2018
BYOND Username: Flaborized
06-18-2024, 06:21 AM
(This post was last modified: 06-18-2024, 06:31 AM by Flaborized. Edited 1 time in total.)
I briefly checked the code for this to see if *other* chameleon outfits had gone outdated (some had) and while I was there I decided to just go ahead and make a fix PR. Rancher seems to already be in the list and fully functional so I just added the courier and fixed some things. Basically nobody (including me) ever remembers to update this thing.
No gimmick outfits added, I don't wanna make the list super long atm, someone else can PR that after if they think it's apt though.
edit: link to PR cuz I forgor
https://github.com/goonstation/goonstation/pull/19576
Posts: 19
Threads: 1
Joined: Oct 2021
BYOND Username: Egregorious
Character Name: Egryg Reus
(06-18-2024, 06:21 AM)Flaborized Wrote: I briefly checked the code for this to see if *other* chameleon outfits had gone outdated (some had) and while I was there I decided to just go ahead and make a fix PR. Rancher seems to already be in the list and fully functional so I just added the courier and fixed some things. Basically nobody (including me) ever remembers to update this thing.
No gimmick outfits added, I don't wanna make the list super long atm, someone else can PR that after if they think it's apt though.
edit: link to PR cuz I forgor https://github.com/goonstation/goonstation/pull/19576
That's some impressively fast turnaround! Thanks!
I must have just been blind when looking for the Rancher entry, my bad. I can understand why people wouldn't want to add more complexity to the item though, so that's fair.