Goonstation Forums › Discussion › Patches › Implemented
[QoL] Dynamic Pod Exit

Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Threaded Mode
[QoL] Dynamic Pod Exit
Tombi
Guest
 
#1
02-28-2018, 05:36 PM
From this thread.

Github pull request

Only affects code/WorkInProgress/Spaceship/vehicle.dm around line 772.
PS. This makes the "floating off into space when leaving a pod bug" more apparent.

EDIT: now includes the floating into space bug fix.
Reply
Frank_Stein Offline
Admin
Posts: 5,708
Threads: 303
Joined: May 2014
#2
02-28-2018, 05:47 PM
Honestly, floating off doesn't matter to me too much as long as it's in the direction I want to be going. Most of the time when I'm getting out of a pod in space it's to reach an airline to get back inside
Find
Reply
Mordent Offline
Developer
Posts: 1,323
Threads: 57
Joined: Jul 2016
BYOND Username: Mordent
#3
02-28-2018, 06:06 PM
You've got the PR link set to compare to the wrong branch. The base branch should be the 2016 one.
Find
Reply
Tombi
Guest
 
#4
03-01-2018, 12:16 AM
(02-28-2018, 06:06 PM)Mordent Wrote: You've got the PR link set to compare to the wrong branch. The base branch should be the 2016 one.
Oh yeah I set it to master, whoops. Fixed.
Reply
Gannets Offline
Developer
Posts: 1,032
Threads: 32
Joined: Oct 2014
#5
03-01-2018, 04:06 AM
This is a good change.
Find
Reply
Tombi
Guest
 
#6
03-01-2018, 04:06 AM
Since I was already changing the code, I fixed the floating off into space bug. You're welcome. Updated the pull request.
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)