[MERGED PR] Potato pipeshot

[github_bot]

PULL REQUEST DETAILS




[GAME OBJECTS][FEATURE][INPUT WANTED][Add to Wiki][balance]
About the PR
This PR adds:
- potato pipeshot **ammo**: made by adding two potatoes to filled pipe hulls

- A potatoslug **projectile** datum: _~They're very weak (5 brute damage, 20 stamina damage, max throw range of 3 tiles) and therefore significantly less harmful than the already existing makeshift ammo types, as well as their real stun slug counterparts. I'm thinking about randomizing the damage between 1-5, or maybe have that depend on the potatoes stats.~_ **\***

- potatosplat **cleanable decals**: The cleanables are spawned manually in the `on_hit` and `on_max_range_die` procs, since bulletholes only spawn at higher damages _(which are handled in the wall code, leading to inconsistencies [potatoes should make splat regardless of how far you shoot them away from])._ Currently, they spawn in the center of the turf the projectile ends up on, instead of where the projectile actually impacts, though I'm not sure if that's an issue.

_**\*** The damage has been buffed to 15 BRUTE, throw range now depends more on projectile power, with the max still being 3. I'm open to changing the damage again, though I believe this to work fairly well._

Demo video (YT link because it's too big of a file): https://youtu.be/KorfhsqE37o?si=tNKNne-CynHnSanH

Since this is one of my first real feature PRs, I'd appreciate feedback on code, sprites, etc.. I'll create the required wiki info as soo as I find out this gets merged.



Why's this needed?
Firstly, this kind of ammo fills a spot in makeshift ammo that isn't filled yet: Slugs. They're now very similar to their brand-made counterparts, but, due to being pipeshot, can only be used in break-actions, putting them in a fairly good spot balance-wise. This PR is inspired by [this forum thread](https://forum.ss13.co/showthread.php?tid=23707) on potato ammo.

Todo:
- [x] projectile datum
- [x] ammo item
- [x] cleanable potato splat
- [x] proj sprite
- [x] cleanable sprite
- [x] ammo sprite
- [x] adjust damage according to feedback

Changelog

Code:

changelog
(u)Chasu
(*)Added potato pipeshot ammo, a makeshift slug equivalent for break-action shotguns.

PULL REQUEST DETAILS

[Lord_earthfire]

I wouldn't worry about the damage values you chosen too much. The damage is so laughable low that it's in a good place as a kind of prank ammunition. Any ranged prot will bump it down to something like 1 - 3 anyway.

Its funny, i like it.

[freedo5]

Personally I'd rather have this be on the grenade launcher rather than pipe shot since they have a funnier sound. Also the range can be extended more for potato fighting.

[Chasu]

Personally I'd rather have this be on the grenade launcher rather than pipe shot since they have a funnier sound. Also the range can be extended more for potato fighting.

Oh, the shot sound can be changed in the ammo item itself. And I'll definitely tweak the range a bit.

[freedo5]

Personally I'd rather have this be on the grenade launcher rather than pipe shot since they have a funnier sound. Also the range can be extended more for potato fighting.

Oh, the shot sound can be changed in the ammo item itself. And I'll definitely tweak the range a bit.

Poggers

[Chasu]

And it's as good as done, out of the draft stage and ready for review.

[Taylorstar]

Would it be too late to suggest having peeled potatos act like birdshot, minimal/0 damage but act like you got hit in the face by a plate of mash or cream pie?

[Chasu]

Would it be too late to suggest having peeled potatos act like birdshot, minimal/0 damage but act like you got hit in the face by a plate of mash or cream pie?

It's not impossible for me to do, do you mean acting like birdshot as in doing minimal damage or as in fragmenting into tiny, near-harmless pieces?

[Taylorstar]

I like the appearance of the birdshot as it flies through the area and the minimal damage seems like a great idea keeping with the theme so I sort of mean both.

[Chasu]

I like the appearance of the birdshot as it flies through the area and the minimal damage seems like a great idea keeping with the theme so I sort of mean both.

Sounds good, I might look into that.

[RSOD]

peeling a potato then frying it before putting it in for birdshot should make it shoot fries..