Goonstation Forums
[feature]I made some dumb item suicides - Printable Version

+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Patches (https://forum.ss13.co/forumdisplay.php?fid=30)
+---- Forum: Implemented (https://forum.ss13.co/forumdisplay.php?fid=31)
+---- Thread: [feature]I made some dumb item suicides (/showthread.php?tid=6042)



[feature]I made some dumb item suicides - atomic1fire - 03-08-2016

https://github.com/goonstation/goonstation-2016/compare/master...atomic1fire:sillycides

Diff I guess

https://github.com/goonstation/goonstation-2016/compare/master...atomic1fire:sillycides.diff

Crowbar is a half life joke, Multitool is a bad pun.

I have no idea what I'm doing, so this could be a terrible patch.

Also I pretty much just copied and pasted the screw driver code, so the damage values are probably wrong somehow.


RE: [feature]I made some dumb item suicides - Haine - 03-10-2016

I'm making some small changes to the messages and thought you might wanna know what they are and why!

Code:
user.visible_message("<span style=\"color:red\"><b>[user] beats /his in the head with a crowbar, like some kind of suicidal theoretical physicist.</b></span>")
VS
Code:
user.visible_message("<span style='color:red'><b>[user] beats [him_or_her(user)]self in the head with a crowbar, like some kind of suicidal theoretical physicist.</b></span>")

The built in \his macro (the direction of the slash is important: /his wouldn't work) doesn't know you want to use "him/her/themself" here, and is kinda iffy on how well it works (sometimes it likes to be confused about which thing you want the gender of - though this message would probably be fine).  him_or_her() and his_or_her() are more reliable since you tell it exactly who's gender you want.

Not a big deal, just an FYI.