+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Bug Reports (https://forum.ss13.co/forumdisplay.php?fid=9)
+--- Thread: Minor Mechanic's PDA sometimes doesn't scan (/showthread.php?tid=13605)
Mechanic's PDA sometimes doesn't scan - DasBrain - 01-12-2020
I noticed that sometimes the Mechanic's PDA doesn't scan items, so you have to scan it multiple times.
This only occurs on space maps, so not on Oshan or Manta.
Today I read some of the code in the 2016 release, and found what is causing this.
When an item is scanned, a random ruckingenur kit is selected where the scan is sent to: https://github.com/goonstation/goonstation-2016/blob/d8a2d60915fd3b74653a1b7d4b8a0910c6fc2f19/code/obj/item/device/pda2/scanners.dm#L103
But the ruckingenur kit will only insert the item into the database if it has power: https://github.com/goonstation/goonstation-2016/blob/d8a2d60915fd3b74653a1b7d4b8a0910c6fc2f19/code/WorkInProgress/Electronics.dm#L423
On space maps, there is one unpowered ruckingenur kit on Bradbury II: https://goonhub.com/maps/cogmap#l=136,110,3;z=2
If this ruckingenur kit is selected, the item is not scanned.
This results in a 75% success chance to scan something with your PDA.
(I know about 4 ruckingenur kits: Station, Tech outpost, Bradbury II, and one in the adventure zone)
Suggested fix: Only select ruckingenur kits that are powered.