Goonstation Forums
[Feature] Mobile Pipe Dispenser Lays Pipe - Printable Version

+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Patches (https://forum.ss13.co/forumdisplay.php?fid=30)
+---- Forum: Implemented (https://forum.ss13.co/forumdisplay.php?fid=31)
+---- Thread: [Feature] Mobile Pipe Dispenser Lays Pipe (/showthread.php?tid=13099)



[Feature] Mobile Pipe Dispenser Lays Pipe - UrsulaMejor - 10-09-2019

Not sure i did the Topic call stuff right, but I'm ~95% confident in the pipe laying.



Currently works on plating and space tiles.

Lays down pipe as you pull/push it and attempts to auto connect pipes.

Can't handle junctions, trunks, etc., but this should help a lot for long distance projects or mass repairs.

prpr: UM-025
https://github.com/goonstation/goonstation-2016/pull/166


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - saccharineChampion - 10-09-2019

Pipe laying always struck me as one of those mechanics that is more clunky than it ought to be, and this definitely helps. +1 and high hopes for this!


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - Couturier - 10-09-2019

I quite like this feature.


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - Adhara In Space - 10-09-2019

nice good


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - Technature - 10-09-2019

Finally, something that will convince people to actually fix those fucking garbage pipes!


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - UrsulaMejor - 02-02-2020

bumping this in the spirit off making station repairs more easier.

If it needs adjustments or anything before merge, please do lemme know


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - Vengarr - 02-03-2020

Merge plz


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - MarkNstein - 02-03-2020

I too, greatly desire this patch.


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - aft2001 - 02-03-2020

for the love of god please yes make this a thing

Who cares if it gives antags another tool to abuse? The only thing they can make is hilariously complicated death traps and those are always fun to watch, on top of this tool making station repairs 10000x times easier.


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - UrsulaMejor - 02-05-2020

since this seems to be a point of confusion, the mobile pipe dispenser is an already existing item in 2020 code that is just a child of the regular dispenser butv with anchored = 0 and a different sprite.

This patch isn't waiting for sprites or code or anything, it can be copy pasted directly into the code block for the existing mobile pipe dispenser


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - kyle2143 - 02-05-2020

I actually brought up merging this patch in admin chat last week. It is really good, but the one issue we had with it was that the dispenser would lay pipes before the object actually got to the next tile which looked kinda weird.

There were two proposed solutions iirc. Use a spawn to make it place the pipe after the time it takes to move is complete. And place a pipe when the dispenser leaves a tile, not when it enters one.


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - UrsulaMejor - 02-05-2020

issue with it laying pipe as it leaves tile is that it needs information from the previous pipe it laid in order to do the with join; this is provided rather nicely with Move() right now since it naturally has new and old loc params. to do it when leaving a tile would require old old loc or something

I think it having a delay is appropriate; some kind of machine sound could also be added to make it a bit less magical" how it lays pipe


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - Silvercloud29 - 02-06-2020

I love this entire thing, the only question I DO have is, what about junction pipes?


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - UrsulaMejor - 02-06-2020

you'll have to dispense those manually from it as you go; they're just too complicated to auto join as you drag


RE: [Feature] Mobile Pipe Dispenser Lays Pipe - pali6 - 02-09-2020

I merged this! And in the process of merging I rewrote most of it, sorry.