Goonstation Forums
[BUG] Can unwrench meteor shield generators from wires while active. - Printable Version

+- Goonstation Forums (https://forum.ss13.co)
+-- Forum: Discussion (https://forum.ss13.co/forumdisplay.php?fid=6)
+--- Forum: Patches (https://forum.ss13.co/forumdisplay.php?fid=30)
+---- Forum: Implemented (https://forum.ss13.co/forumdisplay.php?fid=31)
+---- Thread: [BUG] Can unwrench meteor shield generators from wires while active. (/showthread.php?tid=11089)



[BUG] Can unwrench meteor shield generators from wires while active. - kyle2143 - 09-17-2018

This is a bug with that atmos shield generator/meteor shield generator patch I made a while back I noticed the other day while setting up some meteor shields in response to an oncoming meteor shower.

Basically, if the generator is hit with a wrench  while it's active, it won't unwrench it. You'll just get

I didn't make it pull request because that seemed like overkill for what is essentially 3 lines of code, but I can if someone needs it:

if (active)
    boutput(user, "Disconnecting [src.name] from the power source while active doesn't sound like the best idea.")
    return

It should be placed in line 166 of shield_generator.dm right below the wrench type check.

Here's the line in the pull request:

https://github.com/goonstation/goonstation-2016/blob/d23aa197ac14c79f335efd6dc9ede3e009500d80/code/obj/machinery/shield_generator.dm#L166


RE: [BUG] Can unwrench meteor shield generators from wires while active. - ZeWaka - 10-20-2018

yee